Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

correct spelling #4522

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

correct spelling #4522

wants to merge 1 commit into from
+122 −122

Conversation

t-bltg
Copy link
Collaborator

@t-bltg t-bltg commented Oct 24, 2024 •
edited
Loading

Description

This is a code quality PR (hand corrections) fixing spelling typos (mostly in comments).

There are two ambiguities to be discussed:

  • Tesselation should be spelled Tessellation, but since those are variables, I haven't corrected them in Makie;
  • independant should be spelled independent, but this relates to a function in Bonito.jl so I haven't modified it to avoid disruption.

Type of change

This is a NFC.

@EdsterG
Copy link
Contributor

EdsterG commented Oct 24, 2024

Tesselation is a stuct defined in GeometryBasics.jl. There's a big breaking refactor currently happening, related to GeometryBasics, so might be a good time to correct the spelling? See #4477, #4319, #219.

@t-bltg
Copy link
Collaborator Author

t-bltg commented Oct 24, 2024 •
edited
Loading

Tesselation is a stuct defined in GeometryBasics.jl.

Thanks for the clarification, and the links !
I also think this is best to change it, but I prefer to leave it for another PR, since this would be breaking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
documentation
Projects
PR review
Status: Work in progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@t-bltg @EdsterG